Don't create new nested loops by preventing inlining of continuations inside the handler of a recursive continuation #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekdohibs
requested review from
lukemaurer,
mshinwell,
lthls,
poechsel and
Gbury
as code owners
Ekdohibs
force-pushed
the
dont-create-nested-loops
branch
from
96a6e22
to
3007236
Compare
mshinwell
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables loopify and prevents it from creating a lot of nested loops (since it re-enables loopify in the first commit, it should be reviewed commit-by-commit and not be squashed).