testing warnings #125
Merged
testing warnings #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
testing-warnings
branch
5 times, most recently
from
be2b4ed
to
9556104
Compare
shym
reviewed
Sep 13, 2023
plugins/qcheck-stm/test/dune
Outdated
| @@ -1,3 +1,6 @@ | |||
| (cram | |||
| (deps %{bin:ortac})) | |||
There was a problem hiding this comment.
This should take the complete set of dependencies (package ...) as other tests and be attached to the qcheck-stm package.
There was a problem hiding this comment.
github CI is indeed complaining when trying to install the packages.
plugins/qcheck-stm/test/dune
Outdated
| (target testing_warnings_errors) | ||
| (package ortac-qcheck-stm) | ||
| (deps | ||
| (package ortac-core) |
There was a problem hiding this comment.
This should reuse the same set of dependencies and the setenv setting in the action than other tests.
n-osborne
force-pushed
the
testing-warnings
branch
from
9556104
to
63abb05
Compare
|
Thanks for this review. |
Only the warnings of level warning (and not error) are tested in this commit. The generated `.ml` file is ignored because it does not contain relevant information and the OCaml compiler would complain about it.
The cram test tries to be progressive so it can also be used as documentation.
shym
force-pushed
the
testing-warnings
branch
from
63abb05
to
6663ba6
Compare
|
As it is really a quibble, I just overwrote your branch with a small difference (pushing the addition of the |
|
CI is happy so I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some test for the warning system of the
ortac-qcheck-stmplugin.