Thread joingraph unification (chore) #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR rewrites the two separate
Atomic
andtak
tests insidesrc/thread/thread_joingraph
into one.They were written, quick-and-dirty, over 1 year ago and large left untouched (see the git history).
This is a step toward bringing them closer to the style of the effective
src/threadomain
test.As part of the rewrite it now occasionally triggers an explicit
Gc.minor
call.The rewrite will make it easier to later experiment with and add additional functionality (signal raising, finalizers, ...)
If nothing else, it will also shave a couple of seconds of the test suite run time.