Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread joingraph unification (chore) #376

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jul 14, 2023

The PR rewrites the two separate Atomic and tak tests inside src/thread/thread_joingraph into one.
They were written, quick-and-dirty, over 1 year ago and large left untouched (see the git history).

This is a step toward bringing them closer to the style of the effective src/threadomain test.
As part of the rewrite it now occasionally triggers an explicit Gc.minor call.

The rewrite will make it easier to later experiment with and add additional functionality (signal raising, finalizers, ...)
If nothing else, it will also shave a couple of seconds of the test suite run time.

@jmid
Copy link
Collaborator Author

jmid commented Jul 14, 2023

CI summary:

  • Cygwin trunk/5.2 part1 - timeout during a 4528.5s Lin DSL Out_channel test with Domain shrinking run
  • Windows 5.1 - timeout due to a 11331.5s Lin DSL Out_channel test with Domain shrinking run
  • 2 x Windows trunk/5.2 - timeout during threadomain [ocaml5-issue] Windows failures on threadomain #203

I'll go ahead and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant