Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing test count of STM int64 ref Thread test #390

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Sep 5, 2023

We are seeing occasional failures to trigger a STM int64 ref Thread negative test, e.g., here on macOS ARM64 5.0:
https://ocaml-multicoretests.ci.dev:8100/job/2023-09-04/192503-ci-ocluster-build-e5c445#L1466

random seed: 409068930
generated error fail pass / total     time test name

[ ]    0    0    0    0 /  250     0.0s STM int ref test with Thread
[ ]    0    0    0    0 /  250     0.0s STM int ref test with Thread (generating)
[✓]  250    0    0  250 /  250     2.9s STM int ref test with Thread

[ ]    0    0    0    0 / 1000     0.0s STM int64 ref test with Thread
[✗] 1000    0    0 1000 / 1000    11.2s STM int64 ref test with Thread

--- Failure --------------------------------------------------------------------

Test STM int64 ref test with Thread failed:

Negative test STM int64 ref test with Thread succeeded but was expected to fail

This little PR therefore raises the count from 1000 to 2500.

@jmid jmid changed the title Increasing test count of STM int64 ref test Increasing test count of STM int64 ref Thread test Sep 5, 2023
@jmid
Copy link
Collaborator Author

jmid commented Sep 6, 2023

CI summary:

Overall, that's 4 true positives and 1 false positive out of 55 (46 + 9) jobs.

@jmid jmid merged commit 2f8c2a9 into main Sep 6, 2023
42 of 47 checks passed
@jmid jmid deleted the incr-stm-int64-thread-count branch September 6, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant