Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ocaml-base-compiler.5.0.0~beta1 on bytecode-only architectures #22246

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Oct 12, 2022

This allows the present version of ocaml-base-compiler.5.0.0~beta1 to install. I'm tempted to say we should remove the dependency on ocaml-option-bytecode-only instead until we finally decide to merge the +options package and ocaml-base-compiler into 1.

  • Checked on i686 Debian ocaml-base-compiler.5.0.0~beta1 pulls in the bytecode-only package and doesn't allow its removal
  • Checked on amd64 Ubuntu ocaml-base-compiler.5.0.0~beta1 doesn't pull in ocaml-option-bytecode-only and it can't be added to the switch
  • Checked on amd64 Ubuntu ocaml-base-compiler.4.14.0 likewise doesn't pull in the package and doesn't allow its installation
  • Checked on i686 Debian ocaml-base-compiler.4.14.0 likewise doesn't pull in the package and doesn't allow its installation

ocaml-options-vanilla now pulls in the ocaml-option-bytecode-only iff
OCaml 5 must compile without the native compiler.
ocaml-base-compiler:version < "5" |
ocaml-variants:version < "5" |
arch = "arm64" |
arch = "x86_64" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 this is going to make everyone rebuild all of their switches if they have opam < 2.2 😭

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that mean that every new supported architecture on OCaml 5 will trigger such a rebuild ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, any change in the depends field with opam < 2.2 triggers a rebuild

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it looks like since these are post dependencies it might be fine in the end. From quick testing:

  • opam 2.0 does not do anything
  • opam 2.1 does reinstall just ocaml-options-vanilla
  • opam 2.2 does nothing

But i suppose it requires more testing to be sure

@kit-ty-kate
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants