ocaml 5.0.0~alpha0: conflict with dune >= 3.4 #22512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to the META files that the compiler now ship. This feature has been added in 5.0.0~alpha1. Dune is able to determine that, but only has access to the (major, minor) numbers to do this. So recent versions of dune can not be used with 5.0.0~alpha0. Historically we've added the conflict on the dune side, but this means that we need to keep adding the conflict on new releases. This commit puts in on the other side, which is easier to maintain since no new incompatible versions of the ocaml compiler are expected. (We could also remove the existing conflicts on the dune side, but doing so would cause many existing switches to be rebuilt even for users that are not on alpha0).
|
Looks reasonable. Thanks! |
|
FWIW, I think the constraints should be in the dune opam package. This reduces the work on the solver (AFAIK). The maintenance issue shouldn't be too hard, you can once and for all put a If such a methodology becomes mainstream, I wouldn't know where to annotate upper and lower bounds, at package X or its dependency Y. |
|
In general I agree with you, but this is a one-off for the first alpha of a the new compiler with lots of breaking changes. I think it is a fair exception to the norm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the META files that the compiler now ship. This feature has been added in
5.0.0~alpha1. Dune is able to determine that, but only has access to the (major, minor) numbers to do this. So recent versions of dune can not be used with5.0.0~alpha0.Historically we've added the conflict on the dune side, but this means that we need to keep adding the conflict on new releases. This commit puts in on the other side, which is easier to maintain since no new incompatible versions of the ocaml compiler are expected.
(We could also remove the existing conflicts on the dune side, but doing so would cause many existing switches to be rebuilt even for users that are not on alpha0).