Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minivpt lower bound further #24696

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

jmid
Copy link
Contributor

@jmid jmid commented Oct 27, 2023

minivpt is a dependency in #24677 which is now causing lbvs_consent compilation to fail with:

[ERROR] The compilation of lbvs_consent.2.1.1 failed at "dune build -p lbvs_consent -j 255".

#=== ERROR while compiling lbvs_consent.2.1.1 =================================#
# context              2.2.0~alpha3~dev | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(https://github.com/UnixJunkie/consent/archive/v2.1.1.tar.gz)
# path                 ~/.opam/4.03/.opam-switch/build/lbvs_consent.2.1.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lbvs_consent -j 255
# exit-code            1
# env-file             ~/.opam/log/lbvs_consent-7-697f60.env
# output-file          ~/.opam/log/lbvs_consent-7-697f60.out
### output ###
# File "src/dune", line 6, characters 49-56:
# 6 |   (libraries dolog batteries bitv parmap str zip minivpt cpm))
#                                                      ^^^^^^^
# Error: Library "minivpt" not found.

I believe this is an issue with the obuild version, not making the name minivpt visible to dune.
Locally I can reproduce the issue - and bumping the obuild requirement to 0.1.0 solved it.
The change should benefit other packages that use dune and would want to depend on minivpt.

For context, #24680 added the first obuild lower bound.

While I was at it, I removed a period in the synopsis to make the opam files lint cleanly.

@jmid
Copy link
Contributor Author

jmid commented Oct 27, 2023

The only two CI failures are from lbvs_consent which the ongoing #24677 is trying to address.

@mseri
Copy link
Member

mseri commented Oct 27, 2023

Thanks

@mseri mseri merged commit 6ce4f1b into ocaml:master Oct 27, 2023
1 of 2 checks passed
@jmid jmid deleted the minivpt-lower-bound-take2 branch October 27, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants