Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QCheck revdeps fixes - take 2 #24737

Merged
merged 38 commits into from
Nov 6, 2023
Merged

QCheck revdeps fixes - take 2 #24737

merged 38 commits into from
Nov 6, 2023

Conversation

jmid
Copy link
Contributor

@jmid jmid commented Nov 2, 2023

This PR fixes a next batch of missing qcheck lower bounds spotted in #24703

@jmid
preface.0.1.0 requires qcheck.0.11 to use float_range and float_bound…
066d5ed 
…_exclusive
@jmid
preface.1.0.0 requires qcheck.0.18 which added a ?ratio param to option
3916b45
@jmid
fadbadml.0.1.2 requires qcheck.0.11 to use float_range
aa635fe
@jmid
bencode.2.0 requires qcheck.0.5.3 to use small_list generator
7dbad12
@jmid
dolmen.0.8.1 and 0.9 requires qcheck.0.9 to use qcheck-core
a97cd48
@jmid
regenerate.0.2 requires qcheck.0.8 to use Gen.pure
65582d4
@jmid
spell.0.3 requires qcheck.0.6 to use ~color argument to QCheck_runner…
c21c18e 
….run_tests
@jmid
syslog-message.1.0.0-1.2.0 require qcheck.0.5 to the Gen module
1b78181
@jmid
containers*.3.7 requires qcheck.0.9 to use qcheck-core and qcheck-ounit
edf4ca1
@jmid
containers*.3.6.1 require qcheck.0.9 to use qcheck-core and qcheck-ounit
fdb1724
@jmid
containers*.3.6 require qcheck.0.9 to use qcheck-core and qcheck-ounit
28a87e3
@jmid
containers*.3.5.1 require qcheck.0.9 to use qcheck-core and qcheck-ounit
4ca1246
@jmid
containers*.3.5 require qcheck.0.9 to use qcheck-core and qcheck-ounit
c65d740
@jmid
containers*.3.4 require qcheck.0.9 to use qcheck-core and qcheck-ounit
a1f611f
@jmid
containers*.3.3 require qcheck.0.9 to use qcheck-ounit
7827afe
@jmid
containers*.3.2 require qcheck.0.9 to use qcheck-ounit
901a2fd
@jmid
containers*.3.1 require qcheck.0.9 to use qcheck-ounit
78ed57d
@jmid
containers*.3.0.1 require qcheck.0.9 to use qcheck-ounit
c1800b1
@jmid
containers*.3.0 require qcheck.0.9 to use qcheck-ounit
ab8ac5b
@jmid
gen.{0.5.3,1.0,1.1} require qcheck.0.9 to use qcheck-ounit
867934d
@jmid
iter.{1.2.1,1.3,1.4,1.5} require qcheck.0.9 to use qcheck-ounit
10bfbc7
@jmid
lwd.0.3 requires qcheck.0.9 to use qcheck-ounit
fd6ab2d
@jmid
lwt-pipe.0.1 requires qcheck.0.9 to use qcheck-ounit
265fe6d
@jmid
olinq.0.3 requires qcheck.0.9 to use qcheck-ounit
8ef3766
@jmid
oseq.{0.4.1,0.5} require qcheck.0.9 to use qcheck-ounit
744113b
@jmid
sqlite3_utils.0.1-0.5 require qcheck.0.9 to use qcheck-ounit
acc9aa6
@jmid
tiny_httpd.0.3-0.6 require qcheck.0.9 to use qcheck-ounit
b699149
@jmid
mdx.1.11.0 is missing an odoc-parser upper bound
21bcc26
@jmid
regenerate.0.2 requires 1.0.0 to use mtime.clock.os
8229d21
@jmid
olinq.0.3 requires dune.1.1 in dune-project
49504c8
@jmid jmid marked this pull request as ready for review November 4, 2023 17:31
@jmid
Copy link
Contributor Author

jmid commented Nov 5, 2023

I've added another batch of fixes and I'm starting to run out of steam...
Because of additional missing lower bounds, this is no longer about qcheck revdeps - but revdeps of (patched) revdeps 😬

@jmid jmid mentioned this pull request Nov 6, 2023
Merged
@jmid
Copy link
Contributor Author

jmid commented Nov 6, 2023

  • A ton of revdeps of revdeps failures remain.
  • A bunch of tests fail on 32-bit platforms (arm32 and x86-32)
    • bencode.2.0
    • containers-data.3.0, containers-thread.3.0, containers.3.0
    • iter.1.2.1
    • fadbadml.0.1.2
    • minisat.0.6
    • oseq.0.4.1, oseq.0.5
    • sqlite3_utils.0.4, sqlite3_utils.0.5
  • some ppc64 failures
  • a single s390x failure (containers-thread.3.7)
  • some FreeBSD failures caused by missing g++
  • some macOS homebrew failures

None of these are caused by adding these missing lower bounds.

@mseri
Copy link
Member

mseri commented Nov 6, 2023

I suggest we fix whatever remaining failure when the chance comes. This PR is already large enough and each re0run takes lots of resources.

Thanks!

@mseri mseri merged commit 03e4c97 into ocaml:master Nov 6, 2023
1 check failed
@jmid jmid deleted the qcheck-revdeps-fixes-take2 branch November 6, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmid @mseri