Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] elpi (1.19.5) #26308

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[new release] elpi (1.19.5) #26308

merged 1 commit into from
Aug 2, 2024

Conversation

gares
Copy link
Contributor

@gares gares commented Jul 30, 2024

ELPI - Embeddable λProlog Interpreter

CHANGES:

Requires Menhir 20211230 and OCaml 4.08 or above.

  • Compiler:

    • Improve performance of separate compilation
  • CHR:

    • Syntax extension for constraint declaration.
    • This aims to avoid the overlapping clique error
    • Example: constraint c t x ?- p1 p2 { rule (Ctx ?- ...) <=> (Ctx => ...) }
    • c, t and x are the symbols which should be loaded in the rule of the
      constraint and should be considered as symbols composing the context (Ctx)
      under which p1 and p2 are used.

CHANGES:

Requires Menhir 20211230 and OCaml 4.08 or above.

- Compiler:
  - Improve performance of separate compilation

- CHR:
  - Syntax extension for constraint declaration.
  - This aims to avoid the `overlapping` clique error
  - Example: `constraint c t x ?- p1 p2 { rule (Ctx ?- ...) <=> (Ctx => ...) }`
  - `c`, `t` and `x` are the symbols which should be loaded in the rule of the
    constraint and should be considered as symbols composing the context (`Ctx`)
    under which `p1` and `p2` are used.
@shonfeder
Copy link
Collaborator

There are some interesting CI failures:

extras

    arm32-ocaml-4.14
        elpi.1.19.5
            [tests (failed: Thread.create: Resource temporarily unavailable)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/efc37b9b21fb14f65c8836d6ea57d553a80d82cf/variant/extras,arm32-ocaml-4.14,elpi.1.19.5,tests)
    arm32-ocaml-5.2
        elpi.1.19.5
            [tests (failed: The compilation of elpi.1.19.5 failed at "make tests DUNE_OPTS=-p elpi SKIP=performance_HO SKIP+=performance_FO SKIP+=elpi_api_performance".)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/efc37b9b21fb14f65c8836d6ea57d553a80d82cf/variant/extras,arm32-ocaml-5.2,elpi.1.19.5,tests)
    x86_32-ocaml-4.14
        elpi.1.19.5
            [tests (failed: Thread.create: Resource temporarily unavailable)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/efc37b9b21fb14f65c8836d6ea57d553a80d82cf/variant/extras,x86_32-ocaml-4.14,elpi.1.19.5,tests)
    x86_32-ocaml-5.2
        elpi.1.19.5
            [tests (failed: The compilation of elpi.1.19.5 failed at "make tests DUNE_OPTS=-p elpi SKIP=performance_HO SKIP+=performance_FO SKIP+=elpi_api_performance".)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/efc37b9b21fb14f65c8836d6ea57d553a80d82cf/variant/extras,x86_32-ocaml-5.2,elpi.1.19.5,tests)

E.g.,

# ------------------------------------------------------------------
# Tests: 157
# Passed: 151
# Failed: 6
# Skipped: 0
# ------------------------------------------------------------------
# Log of the first failure: _log/dune+sepcomp1.log
# ------------------------------------------------------------------
# executable: dune
# args: exec tests/sources//sepcomp1.exe -- -I src/
# Error: Thread.create: Resource temporarily unavailable
# ------------------------------------------------------------------
# End log of the first failure: _log/dune+sepcomp1.log
# ------------------------------------------------------------------
# make: *** [Makefile:81: tests] Error 1



<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - build elpi 1.19.5
+- 
- No changes have been performed
# Run eval $(opam env) to update the current shell environment
'opam reinstall --with-test --verbose elpi.1.19.5' failed.
[WARNING] OPAMCONFIRMLEVEL was ignored because CLI 2.0 was requested and it was introduced in 2.1.
[WARNING] OPAMCONFIRMLEVEL was ignored because CLI 2.0 was requested and it was introduced in 2.1.
"/usr/bin/linux32" "/bin/sh" "-c" "opam reinstall --with-test --verbose elpi.1.19.5;
        res=$?;
        test "$res" != 31 && exit "$res";
        export OPAMCLI=2.0;
        build_dir=$(opam var prefix)/.opam-switch/build;
        failed=$(ls "$build_dir");
        partial_fails="";
        for pkg in $failed; do
          if opam show -f x-ci-accept-failures: "$pkg" | grep -qF "\"debian-12\""; then
            echo "A package failed and has been disabled for CI using the 'x-ci-accept-failures' field.";
          fi;
          test "$pkg" != 'elpi.1.19.5' && partial_fails="$partial_fails $pkg";
        done;
        test "${partial_fails}" != "" && echo "opam-repo-ci detected dependencies failing: ${partial_fails}";
        exit 1" failed with exit status 1
2024-07-30 14:10.09: Job failed: Failed: Build failed
2024-07-30 14:10.09: Log analysis:
2024-07-30 14:10.09: >>> 
[ERROR] The compilation of elpi.1.19.5 failed at "make tests DUNE_OPTS=-p elpi SKIP=performance_HO SKIP+=performance_FO SKIP+=elpi_api_performance".
 (score = 20)
2024-07-30 14:10.09: >>> 
# Error: Thread.create: Resource temporarily unavailable
 (score = 48)
2024-07-30 14:10.09: >>> 
[ERROR] The compilation of elpi.1.19.5 failed at "make tests DUNE_OPTS=-p elpi SKIP=performance_HO SKIP+=performance_FO SKIP+=elpi_api_performance".
 (score = 20)
2024-07-30 14:10.09: >>> 
# Error: Thread.create: Resource temporarily unavailable
 (score = 48)
2024-07-30 14:10.09: Thread.create: Resource temporarily unavailable

IIUC as per LPCIC/elpi#234, this is maybe a multicore bug on particular architectures, as per?
ocaml-multicore/multicoretests#374

I'll mark this for merge consideration, but please send word if this is actually a problem you need to investigate or fix, @gares


(btw, I'm always happy to see a new release of Elpi. It's one of my personal favorite packages 😁 )

@mseri
Copy link
Member

mseri commented Aug 2, 2024

The 32 bit resource issue is a known problem in the ci, I need to find the old discussion and send you the link. I think it was on slack though

@mseri mseri merged commit 6ae9c3f into ocaml:master Aug 2, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Aug 2, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants