Revert "Add missing Cmdliner.Manpage.escape calls" #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added |
* OpamArg.dir_sep, an escaped windows separator * OpamArg.escape_path, a function to escape windows paths
|
Sorry for lag - yes, that fix of mine was pretty dumb, yours is much better! 🙂 |
rjbou
added a commit
that referenced
this pull request
Apr 20, 2020
2.0.7 backported commits * Properly escape Windows paths on manpages [#4129 @AltGr @rjbou] * Fix opam installer opam file [#4058 @rjbou] * Fix various warnings [#4132 @rjbou @AltGr - fix #4100] * Fix dune 2.5.0 promote-install-files duplication [#4132 @rjbou ] * opam exec: display command not found message [#4133 @rjbou - fix #4131]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8883517.
This patch makes the cmdliner escapes
$(i,xxx)appear verbatim in theman-page. Probably the solution is to replace the file_sep used, or use
another escaping function instead. @dra27 ?