Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the value of the 'arch' variable when the current OS is 32bit on a 64bit machine #5950

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented May 10, 2024

Fixes #5949

getconf LONG_BIT is POSIX-complient and thus should work on any Unix-like systems (including cygwin)

Tested successfully on Linux, macOS, Cygwin and MSYS2

@dra27
Copy link
Member

dra27 commented May 10, 2024

Thanks for this!! That means that switches on Raspberry Pi OS now install host-arch-arm32 instead of host-arch-arm64 with ocaml/opam-repository#25861.

This seems a sensible change to me?

@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 10, 2024
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kit-ty-kate kit-ty-kate merged commit f9c7df9 into ocaml:master Sep 3, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the fix-arch-32bit-on-64bit branch September 3, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam var arch reports kernel rather than user arch on Raspberry Pi OS
2 participants