Nullify positions of the extensions fields in OpamFile.OPAM.effective_part #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…take the location of the fields into account
kit-ty-kate
force-pushed
the
nullify-pos-effective
branch
from
7811c80
to
872015f
Compare
kit-ty-kate
force-pushed
the
nullify-pos-effective
branch
from
872015f
to
764f282
Compare
|
Failing CI is from benchmark test broken. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6028
Prior to #5636, opam did not traverse the extension fields when testing equality.
Prior to ocaml/opam-repository#25861, very few packages actually had the
x-env-path-rewritefield so the problem did not occur.Users with a fresh install cache saved after an install will also not immediately notice this issue (see #6031)
The issue was that the extension field carries all the positions of the original file and opam files of installed packages are saved in their normalised form which changes the positions of the fields, so when
OpamFile.OPAM.effectively_equalis called it would see a difference in the extension field.