Return parse errors for 2.2/2.3 formats #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
approved these changes
Sep 16, 2024
rjbou
force-pushed
the
format-warning
branch
from
4fbaf02
to
3383802
Compare
Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
opam-file-format has not required a change since opam 2.1, which causes it to report parse errors when opam-version is > 2.1 using a signal. opam was using the format version instead of the client version to determine if these errors are actually parse errors, and was therefore reporting an unsupported format instead of a parse error. Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
Repository parsing and linting use a slightly different parsing route which wasn't checking for future syntax errors. Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
dra27
force-pushed
the
format-warning
branch
from
3383802
to
a216344
Compare
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6188 and addresses the note in #5665 (comment)