Remove [test] package from sklearn instrumentation (open-telemetry#2303)

Fixes open-telemetry#2218
ocelotl · Mar 21, 2024 · 847e8fa · 847e8fa
1 parent e7df01a
commit 847e8fa
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-sklearn/pyproject.toml b/instrumentation/opentelemetry-instrumentation-sklearn/pyproject.toml
@@ -32,10 +32,6 @@ dependencies = [
 instruments = [
   "scikit-learn ~= 0.24.0",
 ]
-test = [
-  "opentelemetry-instrumentation-sklearn[instruments]",
-  "opentelemetry-test-utils == 0.45b0.dev",
-]
 
 [project.entry-points.opentelemetry_instrumentor]
 sklearn = "opentelemetry.instrumentation.sklearn:SklearnInstrumentor"

diff --git a/instrumentation/opentelemetry-instrumentation-sklearn/test-requirements.txt b/instrumentation/opentelemetry-instrumentation-sklearn/test-requirements.txt
@@ -0,0 +1,22 @@
+asgiref==3.7.2
+attrs==23.2.0
+Deprecated==1.2.14
+importlib-metadata==6.11.0
+iniconfig==2.0.0
+joblib==1.3.2
+numpy==1.24.4
+packaging==23.2
+pluggy==1.4.0
+py==1.11.0
+py-cpuinfo==9.0.0
+pytest==7.1.3
+pytest-benchmark==4.0.0
+scikit-learn==0.24.2
+scipy==1.10.1
+threadpoolctl==3.3.0
+tomli==2.0.1
+typing_extensions==4.10.0
+wrapt==1.16.0
+zipp==3.17.0
+-e opentelemetry-instrumentation
+-e instrumentation/opentelemetry-instrumentation-sklearn
diff --git a/tox.ini b/tox.ini
@@ -434,7 +434,7 @@ commands_pre =
 
   prometheus: pip install {toxinidir}/exporter/opentelemetry-exporter-prometheus-remote-write[test]
 
-  sklearn: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn[test]
+  sklearn: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn/test-requirements.txt
 
   sqlalchemy-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/test-requirements-0.txt
   sqlalchemy-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy/test-requirements-1.txt
@@ -580,12 +580,12 @@ commands_pre =
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-boto/test-requirements.txt
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pika[test]
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-aio-pika/test-requirements-2.txt
-  ; python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn[test]
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-redis/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-fastapi/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-jinja2/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-kafka-python/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-remoulade/test-requirements.txt
+  ; pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-sklearn/test-requirements.txt
   python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-confluent-kafka[test]
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-pymemcache/test-requirements-4.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-logging/test-requirements.txt