Drag and Drop cursor overlaps tooltip

[sherief]

See attached picture. I think the tooltip should be offset by the cursor rect so that the mouse cursor doesn't make the first letter or two difficult to read.

[ocornut]

There's code in BeginDragDropSource() that explicitly override the tooltip position:

SetNextWindowPos(g.IO.MousePos);
[...]
BeginTooltip();

I think at the time I felt it looked really strange to have the tooltip offset by the regular amount (you can try by commenting out the call to SetNextWindowPos(), let me know?).

Note that you may call BeginDragDropSource() with ImGuiDragDropFlags_SourceNoPreviewTooltip and call BeginToolTip yourself, but I'd be interested in figuring out the better default behavior.

[sherief]

Thanks for the pointer! I tried offsetting the tooltip by the mouse cursor size and it looks nice enough, I vote for it as a default:

            g.IO.Fonts->GetMouseCursorTexData(g.MouseCursor, &offset, &size, &uv[0], &uv[2]);
            SetNextWindowPos(g.IO.MousePos + size);

[ocornut]

@sherief : I have pushed a change like that now.

I'm intentionally not using GetMouseCursorTexData() for two reasons now:

• there's no guarantee that the user is using the software mouse cursor (in fact it is fairly unlikely right now)
• in case the mouse cursor changes, we don't want the tooltip to be moved

I think using an hard-coded offset + scale satisfy this without overreaching (it's arguably under-engineered but not problematic at the moment).

[sherief]

You're right, I like your solution better!