-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container profile to allow container context to be applied to processes #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awhite456
requested review from
rroupski,
jp-harvey,
pagbabian-splunk and
mikeradka
April 19, 2023 21:55
pagbabian-splunk
previously approved these changes
Apr 19, 2023
rroupski
requested changes
Apr 19, 2023
rroupski
previously approved these changes
Apr 20, 2023
mikeradka
previously approved these changes
Apr 20, 2023
jp-harvey
reviewed
Apr 20, 2023
jp-harvey
previously approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikeradka
requested changes
Apr 21, 2023
rroupski
previously approved these changes
Apr 24, 2023
Aniak5
previously approved these changes
Apr 27, 2023
rroupski
previously approved these changes
Apr 27, 2023
jp-harvey
previously approved these changes
Apr 27, 2023
Signed-off-by: Roumen Roupski <rroupski@gmail.com>
rroupski
dismissed stale reviews from jp-harvey, Aniak5, and themself
via
April 27, 2023 18:27
6cede73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the container profile, it was not possible to associate a process with its container. With the container profile enabled, each
process
object gains acontainer
field, where details about the container the process is executing inside of can be provided. This is useful when monitoring Kubernetes clusters, where multiple containers can be executing on the one host.