test(refactor): use 'toEqual' instead of 'toStrictEqual' with JSON.st…

…ringify in Response assertions (#589) More context in #588
octokit · Jul 19, 2023 · 00919b6 · 00919b6
1 parent 94d8c75
commit 00919b6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 23 deletions.
diff --git a/test/graphql.test.ts b/test/graphql.test.ts
@@ -44,7 +44,7 @@ describe("octokit.graphql()", () => {
 
     const result = await octokit.graphql(query, { login: "octokit" });
 
-    expect(JSON.stringify(result)).toStrictEqual(JSON.stringify(mockResult));
+    expect(result).toEqual(mockResult);
   });
 
   it("GitHub Enterprise Server usage (with option.baseUrl)", async () => {
@@ -84,7 +84,7 @@ describe("octokit.graphql()", () => {
 
     const result = await octokit.graphql(query, { login: "octokit" });
 
-    expect(JSON.stringify(result)).toStrictEqual(JSON.stringify(mockResult));
+    expect(result).toEqual(mockResult);
   });
 
   it("custom headers: octokit.graphql({ query, headers })", async () => {
@@ -113,7 +113,7 @@ describe("octokit.graphql()", () => {
       },
     });
 
-    expect(JSON.stringify(result)).toStrictEqual(JSON.stringify({ ok: true }));
+    expect(result).toEqual({ ok: true });
   });
 
   it("custom headers: octokit.graphql(query, { headers })", async () => {
@@ -145,6 +145,6 @@ describe("octokit.graphql()", () => {
       foo: "bar",
     });
 
-    expect(JSON.stringify(result)).toStrictEqual(JSON.stringify({ ok: true }));
+    expect(result).toEqual({ ok: true });
   });
 });
diff --git a/test/hook.test.ts b/test/hook.test.ts
@@ -118,12 +118,10 @@ describe("octokit.hook", () => {
 
     const { data } = await octokit.request("/");
 
-    expect(JSON.stringify(data)).toStrictEqual(
-      JSON.stringify({
-        ok: true,
-        afterAddition: "works",
-      }),
-    );
+    expect(data).toEqual({
+      ok: true,
+      afterAddition: "works",
+    });
   });
 
   it("octokit.hook.error('request')", async () => {
@@ -161,11 +159,7 @@ describe("octokit.hook", () => {
 
     const { data } = await octokit.request("/");
 
-    expect(JSON.stringify(data)).toStrictEqual(
-      JSON.stringify({
-        ok: true,
-      }),
-    );
+    expect(data).toEqual({ ok: true });
   });
 
   it("octokit.hook.wrap('request')", async () => {
@@ -196,11 +190,7 @@ describe("octokit.hook", () => {
 
     const { data } = await octokit.request("/");
 
-    expect(JSON.stringify(data)).toStrictEqual(
-      JSON.stringify({
-        ok: true,
-      }),
-    );
+    expect(data).toEqual({ ok: true });
   });
 
   it("octokit.hook()", async () => {

diff --git a/test/issues.test.ts b/test/issues.test.ts
@@ -26,8 +26,6 @@ describe("issues", () => {
     const response = await octokit.request("/");
 
     expect(response.status).toEqual(200);
-    expect(JSON.stringify(response.data)).toStrictEqual(
-      JSON.stringify({ ok: true }),
-    );
+    expect(response.data).toEqual({ ok: true });
   });
 });