Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): lock file maintenance #2482

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 19, 2023

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 5am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 19, 2023
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 4968e9b to 879c967 Compare June 20, 2023 23:48
@gr2m
Copy link
Contributor

gr2m commented Jun 20, 2023

This is failing due to type problems with previews I think

test/typescript-validate.ts:26:5 - error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type '{ (params?: (RequestParameters & Omit<ToOctokitParameters<{ parameters: { query?: { milestone?: string | undefined; state?: "all" | "closed" | "open" | undefined; assignee?: string | undefined; ... 7 more ...; page?: number | undefined; } | undefined; path: { ...; }; }; responses: { ...; }; }>, "baseUrl" | ... 1 mor...' is not assignable to parameter of type 'RequestInterface<object>'.
      The types of 'defaults(...).defaults(...).endpoint.DEFAULTS' are incompatible between these types.
        Type 'object & O & O & import("/Users/gregor/code/octokit/octokit.js/node_modules/@octokit/plugin-rest-endpoint-methods/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { ...; }' is not assignable to type 'object & O & O & import("/Users/gregor/code/octokit/octokit.js/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/Users/gregor/code/octokit/octokit.js/node_modules/@octokit/types/dist-types/RequestMethod").RequestMethod; url?: string | undefined; header...'.
          Type 'object & O & O & RequestParameters & { baseUrl: string; method: RequestMethod; url?: string | undefined; headers: RequestHeaders & { ...; }; mediaType: { ...; }; }' is not assignable to type '{ baseUrl: string; method: RequestMethod; url?: string | undefined; headers: RequestHeaders & { accept: string; "user-agent": string; }; mediaType: { format: string; previews: string[]; }; }'.
            The types of 'mediaType.previews' are incompatible between these types.
              Type 'string[] | undefined' is not assignable to type 'string[]'.
                Type 'undefined' is not assignable to type 'string[]'.

26     installationOctokit.rest.issues.listForRepo,

Is this a known issue?

@renovate
Copy link
Contributor Author

renovate bot commented Jun 21, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@kfcampbell
Copy link
Member

I think we need #2456 to go in before this PR...I want to say that this issue will be resolved by bumping the octokit/types.ts version.

@wolfy1339
Copy link
Member

This should be resolved with the wave of updates trickling through. #2456 will definitely fix the issue

@nickfloyd nickfloyd merged commit dce5bd7 into main Jul 19, 2023
7 checks passed
@nickfloyd nickfloyd deleted the renovate/lock-file-maintenance branch July 19, 2023 20:49
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants