Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent splitting multibyte characters in getPayload() #939

Merged
merged 7 commits into from
Dec 4, 2023
Merged

fix: prevent splitting multibyte characters in getPayload() #939

merged 7 commits into from
Dec 4, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 30, 2023 •
edited
Loading

Resolves #938

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Nov 30, 2023
@wolfy1339
Copy link
Member

Can you please add a test to make sure we don't break this behaviour in the future

@wolfy1339
Copy link
Member

Please take the time to fill out the PR templates and use a more descriptive PR title

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2023

@wolfy1339
provided tests as requested. I also run a similar test against the original implementation and got for the multibyte test two broken characters.

@wolfy1339 wolfy1339 changed the title fix: bodyparser in get-payload fix: prevent splitting multibyte characters in getPayload() Dec 2, 2023
@wolfy1339 wolfy1339 mentioned this pull request Dec 2, 2023
Closed
4 tasks
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 2, 2023

@wolfy1339
adapted requested changes

@Uzlopak @wolfy1339
Update test/integration/get-payload.test.ts
bf11f2f 
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@Uzlopak Uzlopak mentioned this pull request Dec 4, 2023
Merged
@wolfy1339 wolfy1339 merged commit fe00834 into octokit:main Dec 4, 2023
6 checks passed
@Uzlopak Uzlopak deleted the fix-bodyparser-in-get-payload branch December 4, 2023 01:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 12.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees
No one assigned
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: bodyparser in get-payload potentially buggy
2 participants
@Uzlopak @wolfy1339