-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct enum
values for required_conversation_resolution_level
, add enum values for PullRequestReview#state
#693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick ask about pull request review values... I just couldn't locate the list.
"state": { "type": "string" }, | ||
"state": { | ||
"type": "string", | ||
"enum": ["commented", "changes_requested", "approved"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could never find a definitive list for this enum from the docs. After parsing it a bit I found examples using both changes_requested
and approved
, but I could never find comment
- would you happen to be able to point me to where you found this list (schema or docs).
Definitely not a show stopper or anything - I'd just like to find out why I am missing this detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it just by comparing payloads of webhooks I received.
A lot of things in these schemas aren't really described in the docs, and we have to infer from the payloads we receive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it... thanks for the clarity.
🎉 This PR is included in version 6.3.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…l`, add enum values for `PullRequestReview#state` (#693) ref: octokit/webhooks.net#91 ref: #689 (comment)
No description provided.