fix a bug of rails trying to use to_ary function. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.ruby-lang.org/issues/5759 There is no to_ary function for Enum::EnumValue, but it does respond to to_ary calls with method_missing. For example, [STATUSES.some_enum_status].flatten will fail on `undefined method 'to_ary'`. So this is meant to indicate rails to not use to_ary on this object
|
@odedniv is it possible to release a version with this fix? |
|
Thanks for the PR! 2 questions:
Will definitely release a version once this PR is merged. |
|
@odedniv Yeah, we don't have capacity to do it now so we will add the change to our Simplee repo for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/5759
There is no to_ary function for Enum::EnumValue, but it does respond to to_ary calls with method_missing.
For example,
[STATUSES.some_enum_status].flattenwill fail onundefined method 'to_ary'.So this is meant to indicate rails to not use to_ary on this object.
Was tested on
Rails 4.2.11 + Ruby 2.3.8