[java] Fix submitting form containing input with name or id "submit" (S…

…eleniumHQ#3398) Signed-off-by: Alexei Barantsev <barancev@gmail.com>
odedniv · Sep 10, 2017 · 865c140 · 865c140
1 parent d7b43ef
commit 865c140
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/java/client/src/org/openqa/selenium/remote/http/W3CHttpCommandCodec.java b/java/client/src/org/openqa/selenium/remote/http/W3CHttpCommandCodec.java
@@ -294,7 +294,7 @@ public W3CHttpCommandCodec() {
           "if (!form.ownerDocument) { throw Error('Unable to find owning document'); }\n" +
           "var e = form.ownerDocument.createEvent('Event');\n" +
           "e.initEvent('submit', true, true);\n" +
-          "if (form.dispatchEvent(e)) { form.submit() }\n",
+          "if (form.dispatchEvent(e)) { HTMLFormElement.prototype.submit.call(form) }\n",
           asElement(parameters.get("id")));
 
       default:

diff --git a/java/client/test/org/openqa/selenium/FormHandlingTest.java b/java/client/test/org/openqa/selenium/FormHandlingTest.java
@@ -308,7 +308,6 @@ public void testCanClickOnAnExternalImplicitSubmitButton() {
   }
 
   @Test
-  @Ignore(value = MARIONETTE, issue = "3398")
   public void canSubmitFormWithSubmitButtonIdEqualToSubmit() {
     String blank = appServer.create(new Page().withTitle("Submitted Successfully!"));
     driver.get(appServer.create(new Page().withBody(
@@ -321,7 +320,6 @@ public void canSubmitFormWithSubmitButtonIdEqualToSubmit() {
   }
 
   @Test
-  @Ignore(value = MARIONETTE, issue = "3398")
   public void canSubmitFormWithSubmitButtonNameEqualToSubmit() {
     String blank = appServer.create(new Page().withTitle("Submitted Successfully!"));
     driver.get(appServer.create(new Page().withBody(