[IMP] added context in invoice onchange_partner_id method #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: the Runbot failed in the website crawler, not it my patch. |
|
Thanks, manually rebased and merged in master at d78192c |
carlosdauden
pushed a commit
to Tecnativa/odoo
that referenced
this pull request
Apr 14, 2020
…fb05acbdffe8e40245dc489fedca [FIX] mass_mailing: remove inactive lists from mass mailing
royle-vietnam
pushed a commit
to royle-vietnam/odoo
that referenced
this pull request
Jun 20, 2024
…240604_01 Merged from upstream 17 240604 01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, since the new API is not in place in the account module, it's essential that existing on_changes pass the context argument so that overriders can properly use the context.
Adding the context argument in the overrider signature is not option as it would make it incompatible with any other module not adding that extra argument.
That is why we need that signature change to pass the context during the v8 18 months or so lifecycle to make 3rd party apps more compatible until the new API is in place is the official addons in v9 or so.
This is essential for localisations for instance.
Thanks.