Skip to content

Commit

Permalink
deps: upgrade to V8 5.0.71.33
Browse files Browse the repository at this point in the history
This picks up the fix for harmony-regexp-properties being enabled
without a flag.

V8-Commit: v8/v8@27ac008
Fixes: nodejs#6251
PR-URL: nodejs#6290
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: ChALkeR - Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
ofrobots committed Apr 20, 2016
1 parent 0899ea7 commit 4fbd375
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 5
#define V8_MINOR_VERSION 0
#define V8_BUILD_NUMBER 71
#define V8_PATCH_LEVEL 32
#define V8_PATCH_LEVEL 33

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
16 changes: 10 additions & 6 deletions deps/v8/src/regexp/regexp-parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -358,13 +358,17 @@ RegExpTree* RegExpParser::ParseDisjunction() {
uc32 p = Next();
Advance(2);
if (unicode()) {
ZoneList<CharacterRange>* ranges = ParsePropertyClass();
if (ranges == nullptr) {
return ReportError(CStrVector("Invalid property name"));
if (FLAG_harmony_regexp_property) {
ZoneList<CharacterRange>* ranges = ParsePropertyClass();
if (ranges == nullptr) {
return ReportError(CStrVector("Invalid property name"));
}
RegExpCharacterClass* cc =
new (zone()) RegExpCharacterClass(ranges, p == 'P');
builder->AddCharacterClass(cc);
} else {
return ReportError(CStrVector("Invalid escape"));
}
RegExpCharacterClass* cc =
new (zone()) RegExpCharacterClass(ranges, p == 'P');
builder->AddCharacterClass(cc);
} else {
builder->AddCharacter(p);
}
Expand Down

0 comments on commit 4fbd375

Please sign in to comment.