Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file to align with PEP 518 #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbigras
Copy link

@mbigras mbigras commented Dec 17, 2022

Hi @ofw,

I added a minimal pyproject.toml file to align with PEP 518—see https://peps.python.org/pep-0518/#build-system-table.

I tested my change with the pip install . command—see shell session.

$ pip install .
# ...
  DEPRECATION: curlify is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for curlify ... done
Successfully installed certifi-2022.12.7 charset-normalizer-2.1.1 curlify-2.2.1 idna-3.4 requests-2.28.1 urllib3-1.26.13
$ cat <<TOML > pyproject.toml
[build-system]
# Minimum requirements for the build system to execute—see https://peps.python.org/pep-0518/#build-system-table.
requires = ["setuptools", "wheel"]  # PEP 508 specifications.
TOML
$ pip install .
# ...
Successfully installed curlify-2.2.1

Please let me know if I should bump the version in setup.py or do anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant