Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ip adapter #128

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Bugfix/ip adapter #128

merged 3 commits into from
Feb 5, 2024

Conversation

hirune924
Copy link
Contributor

@hirune924 hirune924 commented Feb 1, 2024

Motivation

  • Bug fix for ip-adapter not working with batch_size > 1.
  • Fix of the image url used in visualization.

Modification

  • Fix of the mistake in broadcast.
  • Fix of the image url used in visualization.

Results (Optional)

image

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

📚 Documentation preview 📚: https://DiffEngine--128.org.readthedocs.build/en/128/

Copy link
Owner

@okotaku okotaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okotaku
Copy link
Owner

okotaku commented Feb 1, 2024

@hirune924 The diffusers update caused the CI to fail. I am working on a fix.

@hirune924
Copy link
Contributor Author

Apologies, do you know the cause of this error? I've checked the error message, but I can't figure out why this change is triggering the error….

@okotaku
Copy link
Owner

okotaku commented Feb 2, 2024

@hirune924 Your PR is not the reason.

huggingface/diffusers#6573
This PR caused the error.

@hirune924
Copy link
Contributor Author

Thanks for your quick response! It makes things clear for me!

@okotaku okotaku merged commit 71631e9 into okotaku:main Feb 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants