Send group emails correctly #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumukh
commented
Mar 5, 2017
| if action == "accept": | ||
| group.accept(current_user) | ||
| subject = "{0} has accepted the invitation to join your group".format(current_user.email) | ||
| body = "Your group for {0} now has {1} members".format(assignment.display_name, | ||
| len(group.members)) | ||
| group_action_email(group.members, subject, body) | ||
| members = [m.user.email for m in group.members] | ||
| send_emails(members, subject, body) |
There was a problem hiding this comment.
We call send_emails at the bottom of each case - ideas for something better that's a bit more DRY?
|
Going to merge this since our existing implementation is broken - but a quick pass would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously 400'ing because we were passing a list when sendgrid expected a single string (which changed because we upgraded the sendgrid library version a while back)
The "right" way to do this is to use sendgrid personalizations - but that's an issue we can shelve for later #1084