Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle): new component #111

Merged
merged 7 commits into from
May 17, 2023
Merged

Conversation

faithfulojebiyi
Copy link
Contributor

@faithfulojebiyi faithfulojebiyi commented May 13, 2023

cc: #25

@faithfulojebiyi
Copy link
Contributor Author

faithfulojebiyi commented May 13, 2023

I decided to ditch useControllableRef for now and handle the state in the component. I Spent too much time trying to get useControllableRef to work.

I have written an extentsive test for the component and also added stories. Feel free to review and make edits @productdevbook

@YeSuX
Copy link
Collaborator

YeSuX commented May 13, 2023

I decided to ditch useControllableRef for now and handle the state in the component. I Spent too much time trying to get useControllableRef to work.

I have written an extentsive test for the component and also added stories. Feel free to review and make edits @productdevbook

I have already solved the problem with useControllableRef. After the code is merged, I can help you take a look.

@productdevbook productdevbook self-requested a review May 15, 2023 03:45
@faithfulojebiyi
Copy link
Contributor Author

@YeSuX when will this be merged?

@productdevbook
Copy link
Member

i will check soon

@productdevbook productdevbook changed the title feat: (Oku toggle) feat(toggle): new component May 17, 2023
@productdevbook productdevbook merged commit 659fa23 into oku-ui:main May 17, 2023
This was referenced May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants