- Change TemplateOutliningTaggerProvider to fail fast in the injectio…

…n constructor.
olegsych · Jun 15, 2015 · 57df56c · 57df56c
1 parent 8de75f6
commit 57df56c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/T4Toolbox.VisualStudio.Editor/TemplateOutliningTaggerProvider.cs b/src/T4Toolbox.VisualStudio.Editor/TemplateOutliningTaggerProvider.cs
@@ -17,15 +17,19 @@ internal sealed class TemplateOutliningTaggerProvider : ITaggerProvider
 
         public TemplateOutliningTaggerProvider(ITemplateEditorOptions options)
         {
-            // TODO: throw ArgumentNullException
+            if (options == null)
+            {
+                throw new ArgumentNullException(nameof(options));
+            }
+
             this.options = options;
         }
 
         public ITagger<T> CreateTagger<T>(ITextBuffer buffer) where T : ITag
         {
             if (buffer == null)
             {
-                throw new ArgumentNullException("buffer");
+                throw new ArgumentNullException(nameof(buffer));
             }
 
             if (this.options.TemplateOutliningEnabled)

diff --git a/test/T4Toolbox.VisualStudio.Editor.Tests/TemplateOutliningTaggerProviderTest.cs b/test/T4Toolbox.VisualStudio.Editor.Tests/TemplateOutliningTaggerProviderTest.cs
@@ -4,8 +4,8 @@
 
 namespace T4Toolbox.VisualStudio.Editor
 {
+    using System;
     using System.ComponentModel.Composition;
-    using System.Reflection;
     using Microsoft.VisualStudio.Text.Tagging;
     using Microsoft.VisualStudio.Utilities;
     using NSubstitute;
@@ -52,6 +52,21 @@ public void TemplateOutliningTaggerProviderAppliesOnlyToTextTemplateContentType(
             Assert.Equal(TemplateContentType.Name, contentType.ContentTypes);
         }
 
+        [Fact]
+        public void ConstructorThrowsArgumentNullExceptionWhenOptionsIsNullToFailFast()
+        {
+            var e = Assert.Throws<ArgumentNullException>(() => new TemplateOutliningTaggerProvider(null));
+            Assert.Equal("options", e.ParamName);
+        }
+
+        [Fact]
+        public void CreateTaggerThrowsArgumentNullExceptionWhenBufferIsNullToFailFast()
+        {
+            var provider = new TemplateOutliningTaggerProvider(Substitute.For<ITemplateEditorOptions>());
+            var e = Assert.Throws<ArgumentNullException>(() => provider.CreateTagger<OutliningRegionTag>(null));
+            Assert.Equal("buffer", e.ParamName);
+        }
+
         [Fact]
         public void CreateTaggerReturnsTemplateOutliningTagger()
         {