Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest-pipeline): use correct schema in GET #1128

Closed

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Jun 26, 2019

@olivere
Copy link
Owner

olivere commented Jun 30, 2019

Okay. So in 6.x it was like this, and in 7.x it is the same.

I'm not sure with this PR as there seems to be an offset between ES documentation and the actual ES code.

@olivere olivere added this to the 7.0.5 milestone Jun 30, 2019
@jfroche jfroche force-pushed the fix-ingest-pipeline-struct branch from ba08bbc to 2544abb Compare July 2, 2019 20:11
@olivere olivere closed this in 0f67219 Aug 5, 2019
@olivere
Copy link
Owner

olivere commented Aug 5, 2019

I finally checked and your PR is correct. I will release this in 7.0.5, due soon. Thanks again.

@jfroche
Copy link
Contributor Author

jfroche commented Aug 9, 2019

Thank you. Do you think it is a good idea to back port that change in v6 and v5 ?

@phillbaker
Copy link
Contributor

For reference & context, I think the java code is in Pipeline.java, not PipelineConfiguration.java.

The same structure is also used in v5.

@olivere
Copy link
Owner

olivere commented Aug 10, 2019

Thank you. Do you think it is a good idea to back port that change in v6 and v5 ?

Yes, that's probably a good idea.

jfroche pushed a commit to jfroche/elastic that referenced this pull request Aug 12, 2019
jfroche pushed a commit to jfroche/elastic that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants