Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veqryn aws support #839

Merged
merged 4 commits into from
Jul 28, 2018
Merged

Veqryn aws support #839

merged 4 commits into from
Jul 28, 2018

Conversation

veqryn
Copy link
Contributor

@veqryn veqryn commented Jul 25, 2018

Include an actual AWS Signing client as supported in the repo.
The aws stuff is in its own package, so it won't get compiled into the end binary unless it is actually being used.
Also updated the recipe example.


This change is Reviewable

@olivere
Copy link
Owner

olivere commented Jul 25, 2018

I’m not an expert on AWS, so let me check this first. But providing our own solution to make AWS just work out of the box is definitely useful for Elastic users. Thanks.

@olivere
Copy link
Owner

olivere commented Jul 25, 2018

Can you check the errors on Travis please. Looks like a wrong import path...

@veqryn
Copy link
Contributor Author

veqryn commented Jul 25, 2018

I can say that I am using this exact package in production right now, against AWS.

I'm not sure what is going on with travis:

github.com/olivere/aws (download)
# cd .; git clone https://github.com/olivere/aws /home/travis/gopath/src/github.com/olivere/aws
Cloning into '/home/travis/gopath/src/github.com/olivere/aws'...
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/olivere/aws/'
package github.com/olivere/aws: exit status 128

Does it fail because this hasn't been merged yet?

@olivere
Copy link
Owner

olivere commented Jul 26, 2018

I think it’s

github.com/olivere/elastic/aws

not

github.com/olivere/aws

But I can fix it as well, no worries.

@veqryn
Copy link
Contributor Author

veqryn commented Jul 26, 2018

ah, i didn't see that

@olivere olivere merged commit fd8b30f into olivere:release-branch.v6 Jul 28, 2018
@olivere
Copy link
Owner

olivere commented Jul 28, 2018

Merged, thanks. Will be in 6.1.26.

olivere added a commit that referenced this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants