Jleong/change exit behavior #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test doesn't want the child to return an error message after the parent returns even though this was perfectly reasonable with our previous design. We were passing the test earlier due to luck since somehow the child process was terminating early enough due to jitter. Still failing multi-oom due to hanging on qemu and bochs. Still failing syn-read on bochs.
Clean up the thread exit because the child now always exits in one place instead of three possible places.
Still failing multi-oom. Also fails syn-read and exec-missing on bochs.
omegaphoenix
force-pushed
the
jleong/changeExitBehavior
branch
from
6a52b38
to
cd645c0
Compare
Remove thread from parent list if it wasn't removed already. All tests work on qemu. Hallelujah! multi-oom still hangs on bochs and syn-read fails on bochs.
omegaphoenix
commented
Feb 21, 2017
celerysticker
approved these changes
Feb 21, 2017
Refactor so we know when an element is removed by checking that element. All tests pass on qemu. syn-read has an assertion fail in list_next and multi-oom hangs on bochs.
All tests passing on qemu. multi-oom hangs on bochs and syn-read fails.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use semaphore at the end to see when a thread can exit
(after it's status has been retrieved by the parent).
Fix bug where not checking after palloc'ing a file struct.
Fix bug where not removing from parent if done.
Pass all tests on qemu.
Fail multi-oom and syn-read only on bochs.