Fix dnf module crash for non-existent url (ansible#81801)

* ci_complete ci_coverage
omkarlokhande · Oct 3, 2023 · b3408ab · b3408ab
1 parent 116766a
commit b3408ab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/fix-dnf-install-missing-url.yml b/changelogs/fragments/fix-dnf-install-missing-url.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - Fix handling missing urls in ansible.module_utils.urls.fetch_file for Python 3.
diff --git a/lib/ansible/module_utils/urls.py b/lib/ansible/module_utils/urls.py
@@ -2058,7 +2058,7 @@ def fetch_file(module, url, data=None, headers=None, method=None,
     try:
         rsp, info = fetch_url(module, url, data, headers, method, use_proxy, force, last_mod_time, timeout,
                               unredirected_headers=unredirected_headers, decompress=decompress, ciphers=ciphers)
-        if not rsp:
+        if not rsp or (rsp.code and rsp.code >= 400):
             module.fail_json(msg="Failure downloading %s, %s" % (url, info['msg']))
         data = rsp.read(bufsize)
         while data:

diff --git a/test/integration/targets/dnf/tasks/dnf.yml b/test/integration/targets/dnf/tasks/dnf.yml
@@ -510,6 +510,7 @@
     that:
         - "dnf_result is failed"
         - "not dnf_result.changed"
+        - "'Failure downloading' in dnf_result.msg or 'Failed to download' in dnf_result.msg"
 
 - name: verify dnf module outputs
   assert: