Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gisidalite version roll back #181

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Gisidalite version roll back #181

merged 3 commits into from
Aug 17, 2021

Conversation

kahummer
Copy link
Contributor

@kahummer kahummer commented May 13, 2021

Changes included with this PR
When updating the grp-frontend mapbox-gl and react-mapboxgl-js I'm getting this error
Uncaught ReferenceError: _createClass is not defined
The errors seem to be arising since the JavaScript bundle is incompatible with some Babel transforms because of the way it shares code between the main thread and Web Worker. more info on this can be found here. I tried the solutions suggested on mapbox docs but didn't get it to work on Create react app. I've also tried solutions shared here to get V2 working.

  1. Create react app configuration override Craco - https://github.com/gsoft-inc/craco This required major upgrades on react-scripts and other packages on grp-frontend which I feel would not be a good solution for other projects that would want to use this package.
  2. worker-loader - Uncaught ReferenceError: _createClass is not defined (after transpiling with Babel) mapbox/mapbox-gl-js#10173 (comment). After installing this and adding it below imports I still couldn't get V2 to work.

Generally, It looks like the fixes will require customizing our bundlers. Since I didn't get a fix for V2, chose to Rollback the mapbox-gl version to the v1 which has no transpiling issues.

NB* We are still using V1 in reveal web

@kahummer kahummer merged commit 0786794 into master Aug 17, 2021
@kahummer kahummer deleted the gisidalite-publish branch August 17, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants