[Flow EVM] update StateDB to store codes by code hash #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5235 +/- ##
==========================================
- Coverage 58.56% 53.86% -4.71%
==========================================
Files 899 885 -14
Lines 85536 82825 -2711
==========================================
- Hits 50097 44612 -5485
- Misses 31743 34726 +2983
+ Partials 3696 3487 -209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ow/flow-go into ramtin/5198-update-evm-code-storage
ramtinms
commented
Jan 16, 2024
Comment on lines
-138
to
+139
| codeHash := gethTypes.EmptyCodeHash | ||
| codeHash := gethCommon.Hash{} |
There was a problem hiding this comment.
This was a bug that I fixed it in this PR, we should return empty code hash for non-existing accounts
fxamacker
approved these changes
Jan 18, 2024
…ow/flow-go into ramtin/5198-update-evm-code-storage
sideninja
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5198