[Execution node] expose computation usage for scripts #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5299 +/- ##
==========================================
- Coverage 55.71% 55.71% -0.01%
==========================================
Files 1003 1003
Lines 96960 96964 +4
==========================================
- Hits 54022 54019 -3
- Misses 38875 38878 +3
- Partials 4063 4067 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…m:onflow/flow-go into ramtin/exec-expose-comp-usage-for-scripts
ramtinms
changed the title
ramtinms
requested review from
zhangchiqing and
peterargue
and removed request for
yhassanzadeh13
zhangchiqing
approved these changes
Jan 30, 2024
peterargue
approved these changes
Jan 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the execution engine to return the computation usage for scripts.
Follow-up PRs are needed to update the access node code to handle and return the computation usage.