-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow EVM] add blockHash and txHash to tx executed events #5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5387 +/- ##
==========================================
- Coverage 56.02% 55.98% -0.04%
==========================================
Files 965 1024 +59
Lines 89671 99184 +9513
==========================================
+ Hits 50241 55532 +5291
- Misses 35678 39410 +3732
- Partials 3752 4242 +490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
changed the title
Ramtin/5372 update log with txhash
[Flow EVM] add blockHash and txHash to tx executed events
Feb 13, 2024
janezpodhostnik
approved these changes
Feb 15, 2024
sideninja
approved these changes
Feb 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
[Flow EVM] add blockHash and txHash to tx executed events
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Feb 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds blockHash to the transaction executed events, and txHash to the logs.
Note that to minimize the amount of data block hash is on the upper level and not injected in each individual log.