Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] add blockHash and txHash to tx executed events #5387

Merged
merged 10 commits into from
Feb 18, 2024

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Feb 13, 2024

This PR adds blockHash to the transaction executed events, and txHash to the logs.
Note that to minimize the amount of data block hash is on the upper level and not injected in each individual log.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cafb1a6) 56.02% compared to head (cd65921) 55.98%.
Report is 3452 commits behind head on master.

Files Patch % Lines
fvm/evm/handler/handler.go 77.77% 3 Missing and 1 partial ⚠️
fvm/evm/emulator/emulator.go 86.36% 2 Missing and 1 partial ⚠️
fvm/evm/types/block.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5387      +/-   ##
==========================================
- Coverage   56.02%   55.98%   -0.04%     
==========================================
  Files         965     1024      +59     
  Lines       89671    99184    +9513     
==========================================
+ Hits        50241    55532    +5291     
- Misses      35678    39410    +3732     
- Partials     3752     4242     +490     
Flag Coverage Δ
unittests 55.98% <84.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the base branch from master to ramtin/5225-returning-error February 13, 2024 19:52
@ramtinms ramtinms changed the title Ramtin/5372 update log with txhash [Flow EVM] add blockHash and txHash to tx executed events Feb 13, 2024
@ramtinms ramtinms marked this pull request as ready for review February 13, 2024 22:56
Base automatically changed from ramtin/5225-returning-error to master February 16, 2024 23:02
@franklywatson franklywatson added this pull request to the merge queue Feb 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 16, 2024
[Flow EVM] add blockHash and txHash to tx executed events
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 17, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 18, 2024
Merged via the queue into master with commit 8b2113a Feb 18, 2024
51 checks passed
@ramtinms ramtinms deleted the ramtin/5372-update-log-with-txhash branch February 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants