[Access] Sort events returned from index in tx index order - backport #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Access] Sort events returned from index in tx index order
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5444 +/- ##
==========================================
+ Coverage 55.99% 56.01% +0.01%
==========================================
Files 1026 1026
Lines 99815 99824 +9
==========================================
+ Hits 55894 55917 +23
+ Misses 39627 39610 -17
- Partials 4294 4297 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Feb 22, 2024
Guitarheroua
approved these changes
Feb 23, 2024
turbolent
reviewed
Feb 23, 2024
Comment on lines
+49
to
+52
| if events[i].TransactionIndex == events[j].TransactionIndex { | ||
| return events[i].EventIndex < events[j].EventIndex | ||
| } | ||
| return events[i].TransactionIndex < events[j].TransactionIndex |
There was a problem hiding this comment.
Maybe factor the repeated indexing expressions into variables:
Suggested change
| if events[i].TransactionIndex == events[j].TransactionIndex { | |
| return events[i].EventIndex < events[j].EventIndex | |
| } | |
| return events[i].TransactionIndex < events[j].TransactionIndex | |
| a := events[i] | |
| b := events[j] | |
| if a.TransactionIndex == b.TransactionIndex { | |
| return a.EventIndex < b.EventIndex | |
| } | |
| return a.TransactionIndex < b.TransactionIndex |
Comment on lines
+57
to
+62
| cmp := bytes.Compare(events[i].TransactionID[:], events[j].TransactionID[:]) | ||
| if cmp == 0 { | ||
| if events[i].TransactionIndex == events[j].TransactionIndex { | ||
| return events[i].EventIndex < events[j].EventIndex | ||
| } | ||
| return events[i].TransactionIndex < events[j].TransactionIndex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #5404