Collect staged contracts from the storage itself #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
commented
Apr 11, 2024
Co-authored-by: Giovanni Sanchez <108043524+sisyphusSmiling@users.noreply.github.com>
SupunS
force-pushed
the
supun/staged-contracts
branch
from
b1a5c34
to
a27ce3d
Compare
SupunS
force-pushed
the
supun/staged-contracts
branch
from
a609485
to
22c51a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5659 +/- ##
==========================================================
+ Coverage 55.78% 59.79% +4.01%
==========================================================
Files 997 574 -423
Lines 98760 55629 -43131
==========================================================
- Hits 55094 33265 -21829
+ Misses 39400 19927 -19473
+ Partials 4266 2437 -1829
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SupunS
force-pushed
the
supun/staged-contracts
branch
from
dc4806a
to
2f448fe
Compare
janezpodhostnik
approved these changes
Apr 12, 2024
|
|
||
| // Filter-in only the payloads belong to the staging account. | ||
| stagingAccountPayloads := make([]*ledger.Payload, 0) | ||
| for _, payload := range allPayloads { |
There was a problem hiding this comment.
It might be worth checking if allPayloads area already sorted at this point, that would speed up filtering the payloads.
SupunS
force-pushed
the
supun/staged-contracts
branch
2 times, most recently
from
045d6bc
to
3e4988f
Compare
|
@turbolent @janezpodhostnik can you maybe have a one last look, particularly the (last) commits: |
…ow-go into supun/staged-contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for onflow/cadence#3050
Assuming the state/storage that is currently being migrated also contains the staged contracts captured by the MigrationContractStaging, this change will read and collect those staged contracts from the storage itself, so they don't needs to be provided externally as a CSV file, etc.
The old way of providing the staged contracts externally/as an argument (as a CSV file) is still supported. The new approach comes into effect only if they are not externally provided.