Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v1.0.0-preview.47 #6326

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Aug 12, 2024

@turbolent turbolent requested review from a team, j1010001 and janezpodhostnik August 12, 2024 22:27
@SupunS SupunS force-pushed the auto-update-onflow-cadence-v1.0.0-preview.46 branch from 8a4a9ed to 78f29cd Compare August 12, 2024 22:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 41.51%. Comparing base (d63da0e) to head (a06ed0b).

Files Patch % Lines
...util/ledger/migrations/cadence_values_migration.go 38.46% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6326      +/-   ##
==========================================
- Coverage   41.68%   41.51%   -0.18%     
==========================================
  Files        1868     2009     +141     
  Lines      136393   143256    +6863     
==========================================
+ Hits        56851    59466    +2615     
- Misses      73538    77604    +4066     
- Partials     6004     6186     +182     
Flag Coverage Δ
unittests 41.51% <66.66%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @SupunS 👍

@SupunS SupunS changed the title Update to Cadence v1.0.0-preview.46 Update to Cadence v1.0.0-preview.47 Aug 13, 2024
@turbolent
Copy link
Member Author

👍

@SupunS SupunS enabled auto-merge August 13, 2024 01:05
@SupunS SupunS disabled auto-merge August 13, 2024 01:07
@turbolent turbolent added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 3a2217d Aug 13, 2024
55 checks passed
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.0.0-preview.46 branch August 13, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants