Skip to content

Commit

Permalink
rc: Don't start Firefox with -silent option, it causes FF38 crash
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed Jun 7, 2015
1 parent 025b61b commit 5331865
Showing 1 changed file with 0 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ protected void launch(String url) {
try {
homePage = new ChromeUrlConvert().convert(url);
profilePath = makeCustomProfile(homePage);
populateCustomProfileDirectory(profilePath);

log.info("Launching Firefox...");
process = prepareCommand(
Expand All @@ -98,28 +97,6 @@ protected void launch(String url) {
}
}

private void populateCustomProfileDirectory(String profilePath) {
/*
* The first time we launch Firefox with an empty profile directory, Firefox will launch itself,
* populate the profile directory, then kill/relaunch itself, so our process handle goes out of
* date. So, the first time we launch Firefox, we'll start it up at an URL that will immediately
* shut itself down.
*/
CommandLine command = prepareCommand(browserInstallation.launcherFilePath(),
"-profile", profilePath,
"-silent"
);
command.setDynamicLibraryPath(browserInstallation.libraryPath());
log.info("Preparing Firefox profile...");
command.execute();
try {
waitForFullProfileToBeCreated(20 * 1000);
} catch (RuntimeException e) {
command.destroy();
throw e;
}
}

protected CommandLine prepareCommand(String... commands) {
CommandLine command = new CommandLine(commands);
command.setEnvironmentVariable("MOZ_NO_REMOTE", "1");
Expand Down

0 comments on commit 5331865

Please sign in to comment.