Skip to content

Commit

Permalink
# 1296 fix(precompiled test guite): exec bit check omitted on Windows (
Browse files Browse the repository at this point in the history
…#1301)

Co-authored-by: Jacob Grieger <jacob.grieger@siemens-healthineers.com>
  • Loading branch information
jgrieger and jgriegershs authored Nov 10, 2023
1 parent 7161a9d commit 26eea01
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ginkgo/internal/test_suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"path"
"path/filepath"
"regexp"
"runtime"
"strings"

"github.com/onsi/ginkgo/v2/types"
Expand Down Expand Up @@ -192,7 +193,7 @@ func precompiledTestSuite(path string) (TestSuite, error) {
return TestSuite{}, errors.New("this is not a .test binary")
}

if filepath.Ext(path) == ".test" && info.Mode()&0111 == 0 {
if filepath.Ext(path) == ".test" && runtime.GOOS != "windows" && info.Mode()&0111 == 0 {
return TestSuite{}, errors.New("this is not executable")
}

Expand Down

0 comments on commit 26eea01

Please sign in to comment.