Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slices from exp/slices to keep golang 1.20 compat #775

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jul 29, 2024

The #766 introduced dependency to slices but that module is not in the
standard lib in golang 1.20.

Closes: #774

The onsi#766 introduced dependency to slices but that module is not in the
standard lib in golang 1.20.

Closes: onsi#774
@onsi onsi merged commit 5e71dcd into onsi:master Jul 29, 2024
6 checks passed
@liggitt
Copy link

liggitt commented Aug 27, 2024

go 1.20 is out of support, adding the dependency on an unstable x/exp module seems worse to me and is blocking some downstreams from updating (xref kubernetes/kubernetes#126787 (comment))

@onsi
Copy link
Owner

onsi commented Aug 27, 2024

hey @liggitt - happy to pull this out and cut a new release that also bumps the minimum Go version to 1.22.0 which is in keeping with the Ginko/Gomega last-2-go-versions policy

@liggitt
Copy link

liggitt commented Aug 27, 2024

it looks like the use is super minimal... maybe we could just delete an item from a slice or find an item in a slice using a simple loop instead of stdlib slices or x/exp use...?

@onsi
Copy link
Owner

onsi commented Aug 27, 2024

I’ll take a look - but, kinda out of principle, i should be doing a better job of bumping the minimum Go version more consistently to help suss these things out and convey clearly to the community that Ginkgo/Gomega expects you to be on the latest go versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.34.0 cannot be used with golang 1.20
3 participants