Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for flag metadata #426

Merged
merged 3 commits into from
May 24, 2023

Conversation

beeme1mr
Copy link
Member

This PR

  • add support for flag metadata

Related Issues

Fixes #425

Notes

This feature is part of the recently released v0.6.0 of the OpenFeature spec.

How to test

Tests are included for both client and server.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team May 20, 2023 01:59
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #426 (0bfb24c) into main (ec502c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0bfb24c differs from pull request most recent head 51f6be7. Consider uploading reports for the commit 51f6be7 to get more accurate results

@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          23       23           
  Lines        2168     2181   +13     
  Branches      178      180    +2     
=======================================
+ Hits         2156     2169   +13     
  Misses         12       12           
Impacted Files Coverage Δ
packages/client/src/client.ts 97.93% <100.00%> (+0.01%) ⬆️
packages/server/src/client.ts 100.00% <100.00%> (ø)
packages/shared/src/types.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr requested a review from moredip May 20, 2023 02:12
@beeme1mr beeme1mr merged commit 029ec26 into main May 24, 2023
@toddbaert toddbaert deleted the 425-implement-flag-metadata-open-featurespec74c373e branch May 24, 2023 19:44
beeme1mr pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.0.4](shared-v0.0.3...shared-v0.0.4)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.3-experimental](web-sdk-v0.3.2-experimental...web-sdk-v0.3.3-experimental)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* bundlers wrongly resolving server/client modules
([#445](#445))
([6acddd5](6acddd5))
* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr added a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](js-sdk-v1.2.0...js-sdk-v1.3.0)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* bundlers wrongly resolving server/client modules
([#445](#445))
([6acddd5](6acddd5))
* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
lukas-reining pushed a commit that referenced this pull request Jun 29, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement flag metadata: open-feature/spec@74c373e
3 participants