Skip to content

Commit

Permalink
Merge pull request #129 from toddbaert/feat/remove-xformation
Browse files Browse the repository at this point in the history
Remove context transformation, ref in provider hooks
  • Loading branch information
toddbaert authored Aug 10, 2022
2 parents b3a0cc6 + 86cd353 commit 3da57e4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
7 changes: 0 additions & 7 deletions specification.json
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,6 @@
"RFC 2119 keyword": "MUST",
"children": []
},
{
"id": "Requirement 1.6.1",
"machine_id": "requirement_1_6_1",
"content": "The `client` SHOULD transform the `evaluation context` using the `provider's` `context transformer` function if one is defined, before passing the result of the transformation to the provider's flag resolution functions.",
"RFC 2119 keyword": "SHOULD",
"children": []
},
{
"id": "Requirement 2.1",
"machine_id": "requirement_2_1",
Expand Down
8 changes: 0 additions & 8 deletions specification/sections/01-flag-evaluation.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,3 @@ It's recommended to provide non-blocking mechanisms for flag evaluation, particu
> The `evaluation options` structure's `hooks` field denotes an ordered collection of hooks that the client **MUST** execute for the respective flag evaluation, in addition to those already configured.
See [hooks](./04-hooks.md) for details.

#### Context Transformation

##### Requirement 1.6.1

> The `client` **SHOULD** transform the `evaluation context` using the `provider's` `context transformer` function if one is defined, before passing the result of the transformation to the provider's flag resolution functions.
See [context transformation](./02-providers.md#context-transformation) for details.
2 changes: 1 addition & 1 deletion specification/sections/02-providers.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ ResolutionDetails<MyStruct> resolveStructureValue(string flagKey, MyStruct defau

#### Provider hooks

A `provider hook` exposes a mechanism for `providers` to register [`hooks`](./04-hooks.md) to tap into various stages of the flag evaluation lifecycle. As one example, feature flag management systems often need to transform the context structures the user provides.
A `provider hook` exposes a mechanism for `provider authors` to register [`hooks`](./04-hooks.md) to tap into various stages of the flag evaluation lifecycle. These hooks can be used to perform side effects and mutate the context for purposes of the provider. Provider hooks are not configured or controlled by the `application author`.

##### Requirement 2.10

Expand Down

0 comments on commit 3da57e4

Please sign in to comment.