-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed EvaluationOptions from FeatureProvider method signatures #134
Conversation
Signed-off-by: James-Milligan <james@omnant.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a search for "evaluation options
" and it looks like you found all the relevant occurrences. LGTM.
@beeme1mr this is a breaking change (though a minor one)... I know we're not using release plz here, but do we need to annotate the title at all? Should we be validating titles? |
@james-milligan, can you mention that this is a breaking change in the PR comment? I'll make sure to include that information on the release notes. |
We have approval but let's wait to merge this until tomorrow (Aug 25th, 2022) to give others a chance to provide feedback. |
BREAKING CHANGE
#133