OFEP-007: Surfacing flag metadata #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a `flag metadata` field to Evaluation Details and Resolution Details - ask the provider to provide it in Resolution Details - require the SDK to expose it to Evaluation Details Signed-off-by: Pete Hodgson <git@thepete.net>
Signed-off-by: Pete Hodgson <git@thepete.net>
Signed-off-by: Pete Hodgson <git@thepete.net>
beeme1mr
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Is there any way to add this to the spec without changing the IDs of existing requirements? Requirement 1.4.7 would be 1.4.9 if your PR is merged as is. It would be great to avoid that if possible. If it's not, we'll have to clearly communicate the change during a spec release.
toddbaert
reviewed
Dec 20, 2022
toddbaert
reviewed
Dec 20, 2022
|
Hi @moredip, please address the feedback when you have a moment. Thanks! |
Signed-off-by: Pete Hodgson <git@thepete.net>
moredip
force-pushed
the
pete/provider-metadata
branch
from
47b9576
to
67ae5f6
Compare
Signed-off-by: Pete Hodgson <git@thepete.net>
moredip
commented
Jan 11, 2023
Sorry this took so long for me to get to. All feedback is addressed now I believe |
beeme1mr
reviewed
Jan 11, 2023
toddbaert
approved these changes
Jan 12, 2023
InTheCloudDan
approved these changes
Jan 12, 2023
skyerus
reviewed
Jan 13, 2023
toddbaert
reviewed
Jan 13, 2023
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Pete Hodgson <github@thepete.net>
Signed-off-by: Pete Hodgson <git@thepete.net>
Signed-off-by: Pete Hodgson <git@thepete.net>
moredip
force-pushed
the
pete/provider-metadata
branch
from
5d23ea8
to
05852eb
Compare
Signed-off-by: Pete Hodgson <git@thepete.net>
toddbaert
reviewed
Jan 16, 2023
toddbaert
reviewed
Jan 16, 2023
toddbaert
approved these changes
Jan 16, 2023
Co-authored-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Pete Hodgson <github@thepete.net>
beeme1mr
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag metadatafield to Evaluation Details and Resolution Details(co-authored with @justinabrahms)