Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert coco_api to 6031ce1 and add comments #5246

Merged
merged 5 commits into from
May 28, 2021

Conversation

jshilong
Copy link
Collaborator

Revert master to 6031ce1

Motivation

The change of get_cat_ids of coco_api of PR #5243 and PR #5242 may cause bugs of a subclass of CocoDataset such as cityscapes

@jshilong jshilong changed the title Fix get cat ids revert cooc_api to 6031ce1 and add comments May 28, 2021
@jshilong jshilong changed the title revert cooc_api to 6031ce1 and add comments revert coco_api to 6031ce1 and add comments May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #5246 (3483dd6) into master (50b87bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5246   +/-   ##
=======================================
  Coverage   65.29%   65.29%           
=======================================
  Files         276      276           
  Lines       21209    21204    -5     
  Branches     3524     3522    -2     
=======================================
- Hits        13848    13845    -3     
+ Misses       6614     6613    -1     
+ Partials      747      746    -1     
Flag Coverage Δ
unittests 65.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/coco.py 45.84% <ø> (ø)
mmdet/datasets/api_wrappers/coco_api.py 83.33% <100.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b87bc...3483dd6. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 24b6f93 into open-mmlab:master May 28, 2021
@jshilong jshilong deleted the fix_get_cat_ids branch June 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants