Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor Evaluation for translation models #126

Merged
merged 12 commits into from
Oct 13, 2021

Conversation

plyfager
Copy link
Collaborator

Refactor Evaluation for translation models.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #126 (8ff8c4a) into master (7e3aacc) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   75.28%   75.23%   -0.05%     
==========================================
  Files         121      121              
  Lines        8189     8190       +1     
  Branches     1561     1560       -1     
==========================================
- Hits         6165     6162       -3     
- Misses       1609     1611       +2     
- Partials      415      417       +2     
Flag Coverage Δ
unittests 75.23% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/apis/inference.py 48.42% <75.00%> (+0.54%) ⬆️
mmgen/datasets/paired_image_dataset.py 86.04% <100.00%> (ø)
...chitectures/stylegan/generator_discriminator_v1.py 88.70% <0.00%> (-1.13%) ⬇️
mmgen/models/architectures/stylegan/mspie.py 90.59% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3aacc...8ff8c4a. Read the comment docs.

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Maybe we should support online evaluation in translation_eval.py.
  • EvalHook for translation model should be supported as well.

@plyfager
Copy link
Collaborator Author

Of course, the part @LeoXing1996 mentioned is in my plan. I will complete the online evaluation in this PR, and add TranslationEvalHook in a new PR.

@plyfager
Copy link
Collaborator Author

I tested evaluation(include online mode) and inference, and the codes work fine. However, there are some differences between the evaluation results and the previous ones, and I am looking for the reasons.

@@ -67,19 +67,53 @@
]

dataroot = './data/unpaired_facades'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the file name in this PR and keep them consistent with others in MMGEN. The major problem is that in and the position of the dataset information.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the file name correction was done in #118 .

tools/utils/translation_eval.py Outdated Show resolved Hide resolved
tools/utils/translation_eval.py Show resolved Hide resolved
tools/utils/translation_eval.py Show resolved Hide resolved
tools/utils/translation_eval.py Outdated Show resolved Hide resolved
tools/utils/translation_eval.py Outdated Show resolved Hide resolved
@plyfager plyfager changed the title [WIP] Refactor Evaluation for translation models [Feature] Refactor Evaluation for translation models Oct 12, 2021
@nbei nbei merged commit 6dd321d into open-mmlab:master Oct 13, 2021
LeoXing1996 pushed a commit that referenced this pull request Jul 16, 2022
* refactor trans eval

* fix lint

* support online eval

* fix lint

* fix conflicts among infer and eval

* fix lint

* fix pr

* fix configs

* change default to domain b

Co-authored-by: yangyifei <PJLAB\yangyifei@shai14001042l.pjlab.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants