Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Evaluation Hook of Translation Models #127

Merged
merged 6 commits into from
Oct 15, 2021

Conversation

plyfager
Copy link
Collaborator

Support Evaluation Hook of Translation Models by TranslationEvalHook.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #127 (ac7211c) into master (7e3aacc) will decrease coverage by 1.05%.
The diff coverage is 9.23%.

❗ Current head ac7211c differs from pull request most recent head ce6e4eb. Consider uploading reports for the commit ce6e4eb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   75.28%   74.23%   -1.06%     
==========================================
  Files         121      121              
  Lines        8189     8317     +128     
  Branches     1561     1601      +40     
==========================================
+ Hits         6165     6174       +9     
- Misses       1609     1726     +117     
- Partials      415      417       +2     
Flag Coverage Δ
unittests 74.23% <9.23%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/apis/train.py 20.00% <0.00%> (ø)
mmgen/core/evaluation/eval_hooks.py 12.35% <8.59%> (-3.68%) ⬇️
mmgen/core/evaluation/__init__.py 100.00% <100.00%> (ø)
...chitectures/stylegan/generator_discriminator_v1.py 88.70% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3aacc...ce6e4eb. Read the comment docs.

mmgen/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmgen/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmgen/core/evaluation/eval_hooks.py Show resolved Hide resolved
mmgen/core/evaluation/eval_hooks.py Outdated Show resolved Hide resolved
mmgen/core/evaluation/eval_hooks.py Show resolved Hide resolved
@plyfager plyfager changed the title [WIP] Support Evaluation Hook of Translation Models [Feature] Support Evaluation Hook of Translation Models Oct 14, 2021
@@ -136,10 +136,24 @@
exp_name = 'cyclegan_summer2winter_id0'
work_dir = f'./work_dirs/experiments/{exp_name}'
# testA: 309, testB:238
num_images = 238
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would you change the file name to follow the convention of MMGEN?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename them and reorganize configs in #118 .

@nbei nbei merged commit de6cf63 into open-mmlab:master Oct 15, 2021
LeoXing1996 pushed a commit that referenced this pull request Jul 16, 2022
* support translation evaluation during training

* fix lint

* fix priority for eval hook

* fix pr and add evaluation to configs

* solve conflict

Co-authored-by: yangyifei <PJLAB\yangyifei@shai14001042l.pjlab.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants